search

PaloAltoNetworks / terraform-aws-swfw-modules

Terraform Reusable Modules for Software Firewalls on AWS
https://registry.terraform.io/modules/PaloAltoNetworks/swfw-modules/aws
MIT License
8 stars 10 forks source link

fix(module/asg): IAM Policy for Delicense Lambda #12

Closed jogueber closed 4 months ago

jogueber commented 5 months ago

This fixes the wrong IAM policy

jogueber commented 5 months ago

okay fair point @sebastianczech :) we just assumed that everyone stores it a hierarchy I guess :) I adjusted it accordingly to append a slash if needed pls check

sebastianczech commented 5 months ago

/idempotence paths="examples/combined_design_autoscale"

Testing job ID: 7872570446 Job result: FAILURE

sebastianczech commented 5 months ago

/sca

Testing job ID: 7872648345 Job result: FAILURE

sebastianczech commented 5 months ago

Please also fix Terraform documentation as after changing variables description, README needs to be updated too. More details are in https://github.com/PaloAltoNetworks/terraform-aws-swfw-modules/actions/runs/7872648345/job/21478304330#step:10:20.

sebastianczech commented 5 months ago

/sca

Testing job ID: 7873130599 Job result: SUCCESS

sebastianczech commented 5 months ago

/idempotence paths="examples/combined_design_autoscale"

Testing job ID: 7873195387 Job result: FAILURE

sebastianczech commented 5 months ago

/idempotence paths="examples/combined_design_autoscale"

Testing job ID: 7873517788 Job result: SUCCESS

sebastianczech commented 5 months ago

/sca

Testing job ID: 7873573405 Job result: SUCCESS

jogueber commented 5 months ago

Thanks @sebastianczech