[Bug Report] Missing Tags on Launch Template

[jogueber]

Tag propagation on launch template missing

The tags_specification on the launch template does not pass the global tags to all resoures. This is especially problematic if you have tagging requirements for resources (like we have). One fix could be to merge the global tags with the tag specification and apply it to all instances. A fix can be inspired by the one proposed by the issue on the aws-provider

Module Version

2.0.2

Terraform version

No response

Expected behavior

No response

Current behavior

No response

Anything else to add?

No response

[sebastianczech]

PR #17 is merged, so I'm closing the issue.

[romainmorel]

Hi team,

Since this change i have some error messages while creating ASG

Error: creating Auto Scaling Group (palo-asg): ValidationError: You must use a valid fully-formed launch template. Tagging an elastic gpu on create is not yet supported in this region.

It looks like asg/main.tf now defines a local variable :

locals {
[...]
tags_dest                = ["instance", "volume", **"elastic-gpu"**, "network-interface", "spot-instances-request"]
[...]
}

and aws regions eu-west-3 doesn't support tagging on elastic-gpu resources.

Does the elastic-gpu parameter really mandatory here ?

Thanks in advance

[sebastianczech]

@romainmorel this issue was detected yesterday in #29 and there were prepared changes in #30 . It's going to be released soon.

[sebastianczech]

@romainmorel fix is released in version https://github.com/PaloAltoNetworks/terraform-aws-swfw-modules/releases/tag/v2.0.6