PaloAltoNetworks / terraform-aws-swfw-modules

Terraform Reusable Modules for Software Firewalls on AWS
https://registry.terraform.io/modules/PaloAltoNetworks/swfw-modules/aws
MIT License
8 stars 10 forks source link

fix(module/panorama): alias kms variable #21

Closed lstadnik closed 4 months ago

lstadnik commented 4 months ago

Description

A KMS alias variable definition should be provided based on alias or use default AWS managed KMS key. It is required for the logging disks and root disk in Panorama.

Motivation and Context

The KMS should be unified among all examples and modules.

How Has This Been Tested?

If there is no kms_key_alias variable provided or value will be set alias/awk/ebs it will use AWS managed. For custom manage KMS the policy should be applied into key as a prerequisite.

On Panorama disks can be validated: show system disk details

Screenshots (if appropriate)

Types of changes

Checklist

sebastianczech commented 4 months ago

/plan paths="examples/panorama_standalone"

Testing job ID: 8342483119 Job result: SUCCESS

sebastianczech commented 4 months ago

/idempotence paths="examples/panorama_standalone"

Testing job ID: 8342510560 Job result: SUCCESS