search

PaloAltoNetworks / terraform-aws-swfw-modules

Terraform Reusable Modules for Software Firewalls on AWS
https://registry.terraform.io/modules/PaloAltoNetworks/swfw-modules/aws
MIT License
14 stars 11 forks source link

ASG module - Expose health_check_type as a variable #22

Closed romainmorel closed 7 months ago

romainmorel commented 8 months ago

Is your feature request related to a problem?

The default behavior for ASG is to rely on EC2 instance state, but in case of an autoscale architecture we must rely on the healh_checks status by the ELB/GWLB and make sure instances are removed from the target group.

Actually the asg module uses the "default behaivor" and we need to make it configurable by the end user.

Describe the solution you'd like

Let's expose the health_check_type as a variable for asg_submodule, as it is available on the aws tf provider : https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/autoscaling_group#health_check_type

Describe alternatives you've considered.

No response

Additional context

No response

sebastianczech commented 7 months ago

Feature is delivered in #25 , so I'm closing the issue.