feat(module/asg): Introduce Instance Refresh for ASG module

sebastianczech commented 10 months ago

Description

PR introduces new feature for ASG module - instance refresh, which can be customized by allowing to change every possible attribute for instance refresh block.

Motivation and Context

#416

How Has This Been Tested?

Code was tested by extending example isolated_design_autoscale and deploying it in the lab.

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes if appropriate.
[x] All new and existing tests passed.

sebastianczech commented 10 months ago

/help

migara commented 10 months ago

/help

ChatOPS built in help:

Currently supported commands include:

/sca - run all SCA tests via pre-commit
/validate - run terraform validate
/plan - plan the infrastructure (only examples)
/apply - deploy the infrastructure and destroy afterwards (only examples)
/idempotence - test idempotence: deploy, plan and destroy afterwards (only examples).

The 1^st command does not take arguments, the remaining take two:

paths - a space delimitied list of module paths
tf_version - (optional, defaults to the latest available) a space delimited list of Terraform versions to test the infrastrucure against.

Examples:

# run idempotence tests on listed modules with Terraform versions: 1.2 (latest patch available), 1.4 (latest patch available), 1.5.4.
/idempotence paths="examples/combined_design examples/panorama_standalone" tf_version="1.2 1.4 1.5.4"

# run validation tests with the latest available Terraform version on listed modules.
/validate paths="modules/vmseries modules/vpc examples/combined_design"

sebastianczech commented 10 months ago

/validate paths="modules/asg"

Testing job ID: 7447837849 Job result: FAILURE

sebastianczech commented 10 months ago

/idempotence paths="examples/centralized_design_autoscale examples/combined_design_autoscale examples/isolated_design_autoscale"

Testing job ID: 7448915819 Job result: SUCCESS

sebastianczech commented 9 months ago

/idempotence paths="examples/centralized_design_autoscale examples/combined_design_autoscale examples/isolated_design_autoscale" tf_version="1.7"

Testing job ID: 7796107587 Job result: SUCCESS

sebastianczech commented 9 months ago

/idempotence paths="examples/centralized_design_autoscale examples/combined_design_autoscale examples/isolated_design_autoscale" tf_version="1.6"

Testing job ID: 7818138941 Job result: SUCCESS

PaloAltoNetworks / terraform-aws-swfw-modules