Closed sebastianczech closed 5 months ago
/idempotence paths="examples/combined_design"
Testing job ID: 9545688800 Job result: SUCCESS
/idempotence paths="examples/combined_design examples/combined_design_autoscale examples/isolated_design examples/isolated_design_autoscale"
Testing job ID: 9580464230 Job result: SUCCESS
/idempotence paths="examples/centralized_design examples/centralized_design_autoscale examples/panorama_standalone examples/vmseries_standalone"
Testing job ID: 9581436136 Job result: FAILURE Job result: SUCCESS
/idempotence paths="examples/vmseries_standalone"
Testing job ID: 9641433465 Job result: FAILURE Job result: SUCCESS
Description
PR delivers for examples:
combined_design
:combined_design_autoscale
centralized_design
centralized_design_autoscale
isolated_design
isolated_design_autoscale
panorama_standalone
vmseries_standalone
changes:
optional
in order to define whole type of variablevpcs
(it requires to defined Terraform 1.3 as minimum inversions.tf
)vpc_subnet
, add separate keys forvpc
andsubnet
subnet_sets
(without changing internal logic module)Motivation and Context
There were few motivations for this PR:
As in previous year there were prepared
examples
for references architectures, there were done with below assumptions:modules
should not to be rebuild during preparation ofexamples
example.tfvars
(e.g. new VPC, new subnet, additional route via TGW, IGW, NAT Gateway or GWLB endpoint etc.)modules
andexamples
remains the same (Terraform 1.0, so there is no possibility to use optionals inexamples
)modules
(e.g. sets for subnets, NAT gateway, GWLB endpoints etc.) are not going to be changedAbout the need of refactor of AWS modules we were talking multiple times, but we wanted to finish at first refactor of Azure modules - it's was finished already on April in https://github.com/PaloAltoNetworks/terraform-azurerm-swfw-modules/releases/tag/v3.0.0.
In order to define best user friendly
example.tfvars
(according to the Amazon Method - Working Backwards), refactor of internal modules, embedding some logic of existing modules in other modules (e.g. maybesubnet
insidevpc
module?) and rethink ofset
concept needs to be done (it's not in this PR) - this PR introduces fixes for the most painful fragments of the examples. Refactor of AWS modules will take time, this fixes can be introduced quicker.If you still see another improvements in examples (without rebuilding internal modules):
How Has This Been Tested?
Code was tested locally and via ChatOps.
Types of changes
Checklist