feat(MAJOR): Refactor module `vpc`, remove module `subnet_set`

[sebastianczech]

Description

Resolves #62 by:

• remove subnet_set module
• extend vpc module to create subnets and route tables
• simplify subnets creation (not using complex locals from subnet_set module)
• adjust the variables in variables.tf and outputs inoutputs.tf in order that makes sense
• refactor variables e.g. create new variable internet_gateway, which defines object with attributes for IGW creation/usage
• adjust variables description to standard from #53
• add a comment with a link to Terraform Registry before a resource block
• adjust all examples to new approach with vpc module
• adjust CloudNGFW examples to changes delivered for other examples in #49
• change approach for CloudWatch logs group in CloudNGFW (as the same name PaloAltoCloudNGFW has to be used for both examples, groups was created on account used in workflows and in TFVARS we are not creating new log group, we are reusing existing one)

Motivation and Context

53

How Has This Been Tested?

Code was tested locally and via ChatOps.

Types of changes

• New feature (non-breaking change which adds functionality)

Checklist

• [x] I have updated the documentation accordingly.
• [x] I have read the CONTRIBUTING document.
• [ ] I have added tests to cover my changes if appropriate.
• [x] All new and existing tests passed.

[sebastianczech]

/idempotence paths="examples/cloudngfw_combined_design examples/cloudngfw_isolated_design"

Testing job ID: 10177600450 Job result: FAILURE

[sebastianczech]

/idempotence paths="examples/centralized_design examples/centralized_design_autoscale examples/combined_design examples/combined_design_autoscale examples/isolated_design examples/isolated_design_autoscale examples/panorama_standalone examples/vmseries_standalone"

Testing job ID: 10178193597 Job result: FAILURE

[sebastianczech]

/idempotence paths="examples/centralized_design examples/centralized_design_autoscale examples/combined_design examples/combined_design_autoscale examples/isolated_design examples/isolated_design_autoscale examples/panorama_standalone examples/vmseries_standalone"

Testing job ID: 10180773803 Job result: FAILURE Job result: FAILURE Job result: FAILURE Job result: SUCCESS

[sebastianczech]

/idempotence paths="examples/cloudngfw_combined_design examples/cloudngfw_isolated_design"

Testing job ID: 10181481847 Job result: FAILURE

[sebastianczech]

/idempotence paths="examples/centralized_design examples/centralized_design_autoscale examples/combined_design examples/combined_design_autoscale examples/isolated_design examples/isolated_design_autoscale examples/panorama_standalone examples/vmseries_standalone examples/cloudngfw_combined_design examples/cloudngfw_isolated_design"

Testing job ID: 10193841826 Job result: FAILURE

[sebastianczech]

/idempotence paths="examples/centralized_design examples/centralized_design_autoscale examples/combined_design examples/combined_design_autoscale examples/isolated_design examples/isolated_design_autoscale"

Testing job ID: 10194992834 Job result: SUCCESS

[sebastianczech]

/idempotence paths="examples/panorama_standalone examples/vmseries_standalone"

Testing job ID: 10195370346 Job result: SUCCESS

[sebastianczech]

/idempotence paths="examples/cloudngfw_combined_design examples/cloudngfw_isolated_design"

Testing job ID: 10196534585 Job result: SUCCESS

[sebastianczech]

As we agreed, I changed destination branch from main to develop , from which we can create release candidates.

[sebastianczech]

/plan paths="examples/centralized_design examples/centralized_design_autoscale examples/combined_design examples/combined_design_autoscale examples/isolated_design examples/isolated_design_autoscale examples/panorama_standalone examples/vmseries_standalone examples/cloudngfw_combined_design examples/cloudngfw_isolated_design"

Testing job ID: 10199525688 Job result: SUCCESS