feat(module/vpc_route): Refactor `vpc_route` module - move and simplify locals

[sebastianczech]

Description

Resolves #70

Motivation and Context

53

How Has This Been Tested?

Code was tested locally and via ChatOps.

Types of changes

• New feature (non-breaking change which adds functionality)

Checklist

• [x] I have updated the documentation accordingly.
• [x] I have read the CONTRIBUTING document.
• [ ] I have added tests to cover my changes if appropriate.
• [x] All new and existing tests passed.

[sebastianczech]

/plan paths="examples/combined_design"

Testing job ID: 10367589513 Job result: SUCCESS

[sebastianczech]

/plan paths="examples/combined_design"

Testing job ID: 10387041243 Job result: SUCCESS

[sebastianczech]

/plan paths="examples/centralized_design examples/centralized_design_autoscale examples/combined_design examples/combined_design_autoscale examples/isolated_design examples/isolated_design_autoscale examples/panorama_standalone examples/vmseries_standalone examples/cloudngfw_combined_design examples/cloudngfw_isolated_design"

Testing job ID: 10509587002 Job result: FAILURE Job result: SUCCESS

[sebastianczech]

/plan paths="examples/centralized_design examples/centralized_design_autoscale examples/combined_design examples/combined_design_autoscale examples/isolated_design examples/isolated_design_autoscale examples/panorama_standalone examples/vmseries_standalone examples/cloudngfw_combined_design examples/cloudngfw_isolated_design"

Testing job ID: 10579918053 Job result: SUCCESS

[sebastianczech]

As I'm not a part of Palo Alto Networks organisation anymore, I cannot merge changes from rc branch into refactor_vpc_route branch to resolve conflicts in this branch. Can somebody from repository owners do it or should I create fork of that repository and open new PR with resolved conflicts ?

[sebastianczech]

I resolved conflicts by forking repository and opening new PR https://github.com/PaloAltoNetworks/terraform-aws-swfw-modules/pull/79. If you agree on changes in #79, please close this PR without merging.