PaloAltoNetworks / terraform-aws-vmseries-modules

Terraform Reusable Modules for VM-Series on AWS
https://registry.terraform.io/modules/PaloAltoNetworks/vmseries-modules/aws
MIT License
40 stars 49 forks source link

Additional documentation for next_hop_set in vpc_route #212

Closed mitch-pan closed 2 years ago

mitch-pan commented 2 years ago

Documentation link

https://github.com/PaloAltoNetworks/terraform-aws-vmseries-modules/tree/develop/modules/vpc_route

Describe the problem

Requesting that we add more information about the options for type in the next_hop_set field of vpc_route. Would also be awesome if we put in an example of an interface next_hop_set.

Suggested fix

Something along the lines of adding the following to the documentation for next_hop_set as well as another example in addition to what we already have.

Value arguments for type are:

"transit_gateway" "internet_gateway" "nat_gateway" "interface" "vpc_endpoint" "vpc_peer" "egress_only_gateway" "local_gateway"

Example for adding a route to a VM-Series interface:

next_hop_set = {
        type = "interface"
        id   = null
          ids  = {
            "us-west-1a" = module.vmseries-modules_vmseries["vmseries01"].interfaces["private"].id
          }
      }
welcome-to-palo-alto-networks[bot] commented 2 years ago

:tada: Thanks for opening your first issue here! Welcome to the community!

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 0.3.0 :tada:

The release is available on Terraform Registry and GitHub release

Posted by semantic-release bot