PaloAltoNetworks / terraform-aws-vmseries-modules

Terraform Reusable Modules for VM-Series on AWS
https://registry.terraform.io/modules/PaloAltoNetworks/vmseries-modules/aws
MIT License
40 stars 49 forks source link

feat(module/panorama): Add ability to define AMI ID for Panorama #395

Closed littlejo closed 1 year ago

littlejo commented 1 year ago

Description

I have a trouble of replacing EC2 panorama because ami can change. So i proposed to be able to set ami_id.

sebastianczech commented 1 year ago

/validate paths="modules/panorama"

Testing job ID: 6612175509 Job result: SUCCESS

sebastianczech commented 1 year ago

/plan paths="examples/panorama_standalone"

Testing job ID: 6612208319 Job result: SUCCESS

littlejo commented 1 year ago

Thank for putting in this PR all changes in code, which I asked in comments for #394, which was closed by you. Why previous PR was closed ?

I made a mistake in my Git commands.

littlejo commented 1 year ago

Hello, do you know what it's blocked ?

sebastianczech commented 1 year ago

If you create PR from fork, then our GitHub Actions doesn't allow automatically execute terraform plan (it's by design), that's why I was via ChatOps checking terraform validate and terraform plan:

Both pipeline finished successfully, so let's wait for one more review from other code owner and we will merge this PR