PaloAltoNetworks / terraform-aws-vmseries-modules

Terraform Reusable Modules for VM-Series on AWS
https://registry.terraform.io/modules/PaloAltoNetworks/vmseries-modules/aws
MIT License
40 stars 49 forks source link

feat(module/asg): Introduce Instance Refresh for ASG module #418

Closed sebastianczech closed 10 months ago

sebastianczech commented 11 months ago

Description

PR introduces new feature for ASG module - instance refresh, which can be customized by allowing to change every possible attribute for instance refresh block.

Motivation and Context

416

How Has This Been Tested?

Code was tested by extending example isolated_design_autoscale and deploying it in the lab.

Types of changes

Checklist

sebastianczech commented 11 months ago

/help

ChatOPS built in help:

Currently supported commands include:

The 1st command does not take arguments, the remaining take two:

Examples:

# run idempotence tests on listed modules with Terraform versions: 1.2 (latest patch available), 1.4 (latest patch available), 1.5.4.
/idempotence paths="examples/combined_design examples/panorama_standalone" tf_version="1.2 1.4 1.5.4"
# run validation tests with the latest available Terraform version on listed modules.
/validate paths="modules/vmseries modules/vpc examples/combined_design"
sebastianczech commented 11 months ago

/idempotence paths="examples/centralized_design_autoscale examples/combined_design_autoscale examples/isolated_design_autoscale"

Testing job ID: 7253921886 Job result: SUCCESS

sebastianczech commented 10 months ago

Changes are going to be deployed in new repository in PR https://github.com/PaloAltoNetworks/terraform-aws-swfw-modules/pull/3