PaloAltoNetworks / terraform-azurerm-vmseries-modules

Terraform Reusable Modules for VM-Series on Azure
https://registry.terraform.io/modules/PaloAltoNetworks/vmseries-modules/azurerm/latest
MIT License
49 stars 59 forks source link

refactor(module/virtual_network_gateway): Refactor module for VNG #339

Closed sebastianczech closed 1 year ago

sebastianczech commented 1 year ago

Description

PR delivers changes for VNG:

Motivation and Context

307 , #333

How Has This Been Tested?

I checked that module using example included in PR.

Types of changes

Checklist

acelebanski commented 1 year ago

Hi Sebastian, shouldn't you make name a mandatory property everywhere in the module and get rid of prefix/suffix etc.? In order to move the entire name generation logic to example?

sebastianczech commented 1 year ago

@acelebanski thank you for feedback. I removed name_prefix and name_suffix. All resources have name attribute.