refactor(module/vnet_peering): 336 vnet peering refactor - Githubissues

PaloAltoNetworks / terraform-azurerm-vmseries-modules

Terraform Reusable Modules for VM-Series on Azure

https://registry.terraform.io/modules/PaloAltoNetworks/vmseries-modules/azurerm/latest

MIT License

49 stars 59 forks source link

refactor(module/vnet_peering): 336 vnet peering refactor #341

Closed acelebanski closed 1 year ago

acelebanski commented 1 year ago

Description

PR delivers changes for VNET peering:

README.md adjusted to new style with additional header file
minimum Terraform version set to 1.3
refactor variables:
- descriptions
- types with optionals
- default values
simplify main.tf by removing not required try
remove name generation logic from the module

Motivation and Context

https://github.com/PaloAltoNetworks/terraform-azurerm-vmseries-modules/issues/307

How Has This Been Tested?

Tested that module with internal example where I had to peer spoke VNET.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes if appropriate.
[x] All new and existing tests passed.

acelebanski commented 1 year ago

I think this branch was based on main, it should have been based on 307 branch, otherwise you miss the tf_docs configuration.

You can see that in the README format

Hi, thanks for spotting this. I rebased this branch onto 307 branch.