PaloAltoNetworks / terraform-google-vmseries-modules

Terraform Reusable Modules for VM-Series on Google Cloud Platform (GCP)
https://registry.terraform.io/modules/PaloAltoNetworks/vmseries-modules/google
MIT License
16 stars 27 forks source link

create_public_ip always creates public IP if either true or false #125

Closed ntwrkguru closed 1 year ago

ntwrkguru commented 2 years ago

Describe the bug

When using the vmseries module, specifying any value for create_public_ip parameter results in a public IP address being created. The only way to not have a public IP is to omit the field.

Expected behavior

create_public_up = false should not create a public IP address

Current behavior

When using the vmseries module, specifying any value for create_public_ip parameter results in a public IP address being created. The only way to not have a public IP is to omit the field.

Possible solution

Steps to reproduce

  network_interfaces = [
    {
      subnetwork       = module.vpc.subnetworks["${var.name_prefix}outside"].self_link
      private_address  = each.value.private_ips["outside"]
      create_public_ip = false
    }

Screenshots

Context

Your Environment

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 0.4.0 :tada:

The release is available on Terraform Registry and GitHub release

Posted by semantic-release bot