Closed ancoleman closed 1 year ago
not sure why the validate fails, as I most definitely have this functioning with Terraform 1.3.9
Delicensing code has been merged into autoscale
example with some minor changes:
:tada: Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! :heart:
Description
When utilizing Google Cloud Autoscaling (Managed Instance Groups with Autoscaler Enabled), automatically de-register a firewall with the Panorama Software License Plugin is needed. This de-registration allows the customer to reallocate licenses to their Software NGFW Credit Deployment Profile(s).
Motivation and Context
The drive to support the automatic de-registration of firewalls within Panorama, is to help minimize the operational overhead of knowing when to de-register an abandoned firewall and which firewall to de-register. This module builds all the necessary components to support the de-registration lifecycle of the firewall.
How does this work?
Other Items Built by the Module:
How Has This Been Tested?
This was tested locally on MacOS Ventura using Terraform Version 1.3.9. Pre-commit was performed and all checks passed. An exclusion was necessary for Checkov as there is a false positive on not securing the CFN properly. However, the false positive is due to HTTP trigger not being set to SECURE_ALWAYS. HTTP Trigger is irrelevant for this CFN as it is event-driven with Pub/Sub instead. Checkov should revise their rule to enforce ONLY if http_trigger = true or if event_trigger is present to ignore.
Screenshots (if appropriate)
Types of changes
Checklist