PaloAltoNetworks / terraform-provider-cloudngfwaws

The Terraform provider for the Palo Alto Networks AWS cloud NGFW
Mozilla Public License 2.0
14 stars 14 forks source link

fix: ngfw subnet_mapping change from TypeList to TypeSet #31

Closed ahuseby closed 2 months ago

ahuseby commented 2 months ago

Description

fixes https://github.com/PaloAltoNetworks/terraform-provider-cloudngfwaws/issues/30

Motivation and Context

Bugfix for input subnet_mappings in the ngfw resource. See issue: https://github.com/PaloAltoNetworks/terraform-provider-cloudngfwaws/issues/30.

How Has This Been Tested?

Tested by planning and applying locally on my macbook. If I adjust the number of subnet mappings, e.g I have 3 subnet mappings to eu-north-1a, eu-north-1b, eu-north-1c and remove the one for eu-north-1c, it looks like all 3 are removed then re-added. However this seems to only be only how Terraform observes and updates the state; in NGFW only the relevant endpoint is removed.

Currently there are no acceptance tests for this resource. Writing tests for ngfw resource requires an AWS account for provisioning VPC resources.

Screenshots (if appropriate)

n/a

Types of changes

Bug fix

Checklist

ahuseby commented 2 months ago

https://github.com/PaloAltoNetworks/terraform-provider-cloudngfwaws/issues/30 seems to have been caused by a tainted ngfw instance.