PaloAltoNetworks / terraform-provider-panos

Terraform Panos provider
https://www.terraform.io/docs/providers/panos/
MIT License
89 stars 73 forks source link

Adding argument for keepers in the resource vm auth key #286

Closed Eric-Jckson closed 2 years ago

Eric-Jckson commented 3 years ago

Description

Add support to recreate vm auth token with an argument named keepers. Adding this functionality to recreate token if resources change/update or to be used with the terraform resource time_rotating.

Motivation and Context

This allows the token to be recreated when the token expires using the terraform resource time_rotating.

Example:

resource "time_rotating" "example" {
  rotation_hours = 24
}

resource "panos_vm_auth_key" "example" {
    hours = 24
    keepers = {
        rotate = time_rotating.example.rotation_rfc3339
    }
}

How Has This Been Tested?

Have tested it on a new Palo instance in Azure

Screenshots (if appropriate)

image

Types of changes

Checklist

welcome-to-palo-alto-networks[bot] commented 3 years ago

:tada: Thanks for opening this pull request! We really appreciate contributors like you! :raised_hands:

Eric-Jckson commented 3 years ago

Hey @shinmog ! Do you know if anything else I need to add for this pull request? Just want to make sure im following the right process.

Eric-Jckson commented 3 years ago

Hey @shinmog , anything else i need to add for this pull request?

Eric-Jckson commented 2 years ago

Hey @shinmog , anything else i need to add for this pull request?

shinmog commented 2 years ago

@Eric-Jckson

This looks good, will include it in the next release (either today or tomorrow).

welcome-to-palo-alto-networks[bot] commented 2 years ago

:tada: Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! :heart:

Eric-Jckson commented 2 years ago

Thanks @shinmog !