bugfix: make nat_rule_group work with panorama and ngfw - Githubissues

PaloAltoNetworks / terraform-provider-panos

Terraform Panos provider

https://www.terraform.io/docs/providers/panos/

MIT License

89 stars 73 forks source link

bugfix: make nat_rule_group work with panorama and ngfw #352

Open pimielowski opened 2 years ago

pimielowski commented 2 years ago

Description

Based on documentation nat_rule_group should work either with Panorama and NGFW, right now it not work as intended.

quick fix for ike_crypto_profile_tests.

Motivation and Context

It fix nat_rule_group resource to behave what was said in documentation.

How Has This Been Tested?

I build provider, test it with Terraform code and do go tests.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

[x] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes if appropriate.
[x] All new and existing tests passed.

welcome-to-palo-alto-networks[bot] commented 2 years ago

:tada: Thanks for opening this pull request! We really appreciate contributors like you! :raised_hands:

georgegil commented 6 months ago

Shocking that this PR has been open since 2022 and nobody has bothered to merge or whatever with it

One has to wonder if Palo is actually bothered about TF support, and if this repo is still alive?