PaloAltoNetworks / terraform-provider-panos

Terraform Panos provider
https://www.terraform.io/docs/providers/panos/
Mozilla Public License 2.0
87 stars 69 forks source link

Added capability to put login banner using general_settings #372

Open jinfluenza opened 1 year ago

jinfluenza commented 1 year ago

Description

This PR is to add capability to put login banner using general settings resource block

Motivation and Context

As we try to automate further, I feel that a lot of consumer will benefit from having an ability to add login banner programmatically. While making this change I noticed that Pango already has login banner in its config, so I just needed to enable login banner within provider code base.

How Has This Been Tested?

This was tested via Panos environment

This was tested on VM-series of Pan OS deployed in Cloud and applying the changes using the Terraform to the instance.

Types of changes

Checklist

welcome-to-palo-alto-networks[bot] commented 1 year ago

:tada: Thanks for opening this pull request! We really appreciate contributors like you! :raised_hands:

jinfluenza commented 1 year ago

Hi @shinmog! Just wanted to see if you had a chance to look at this PR. I have more coming to add more features, but wanted to see I am following your structure with this small PR. lmk if you have any suggestions!

shinmog commented 1 year ago

@jinfluenza Rebase when you get a chance and I can merge this enhancement

jinfluenza commented 1 year ago

@shinmog it has been rebased. thank you!

AYDEV-FR commented 5 months ago

I'm also interested in this merge request. Can it be merged?