Document is incorrect for `panos_security_policy` - Githubissues

PaloAltoNetworks / terraform-provider-panos

Terraform Panos provider

https://www.terraform.io/docs/providers/panos/

MIT License

89 stars 73 forks source link

Document is incorrect for `panos_security_policy` #398

Open phuongdnguyen opened 1 year ago

phuongdnguyen commented 1 year ago

Documentation link

Describe the problem

Is the warning for panos_security_policy correct ? Because i see that in https://github.com/PaloAltoNetworks/terraform-provider-panos/blob/4aac7586c49af3e1ffef11224d4a31616125e159/panos/security_rules.go#L207 , isPolicy is set to false, which is: If isPolicy is true, then any rules not explicitly present in the rules param will be deleted. as in https://github.com/PaloAltoNetworks/pango/blob/dba4c1566648dbf17471e4cae313d7ebe1846b68/poli/nat/pano.go#L70:L71

Suggested fix

Update the documentation

welcome-to-palo-alto-networks[bot] commented 1 year ago

:tada: Thanks for opening your first issue here! Welcome to the community!