PaloAltoNetworks / terraform-provider-panos

Terraform Panos provider
https://www.terraform.io/docs/providers/panos/
MIT License
89 stars 73 forks source link

provider documentation on hashicorp uses an invalid argument in panos_general_settings example #433

Open ahmutysj3 opened 7 months ago

ahmutysj3 commented 7 months ago

Documentation link

https://registry.terraform.io/providers/PaloAltoNetworks/panos/latest/docs/resources/general_settings

Describe the problem

The example used in the provider documentation for the panos_general_settings resource uses the argument ntp_primary but the correct attribute (listed later on in the argument references) is ntp_primary_address


## Suggested fix

update the example to this 

resource "panos_general_settings" "example" { hostname = "ngfw220" dns_primary = "10.5.1.10" ntp_primary_address = "10.5.1.10" ntp_primary_auth_type = "none"

lifecycle {
    create_before_destroy = true
}

}