PaloAltoNetworks / terraform-provider-prismacloudcompute

Terraform provider for Prisma Cloud Compute
https://registry.terraform.io/providers/PaloAltoNetworks/prismacloudcompute/latest
Mozilla Public License 2.0
24 stars 28 forks source link

Add admission policies resource #32

Closed hi-artem closed 2 years ago

hi-artem commented 3 years ago

Is your feature request related to a problem?

We want to be able to manage our Admission policies using Terraform

Describe the solution you'd like

Add Terraform resource allowing to manage Admission policies

Additional Context

It looks like this would require additions to https://github.com/PaloAltoNetworks/prisma-cloud-compute-go

hi-artem commented 3 years ago

I will start working on this issue myself, but just want to open PR to track it.

wfg commented 2 years ago

Can you pull main branch and test using the SDK's main branch as well? If all works as expected, I'll close this issue and tag for release.

hi-artem commented 2 years ago
❯ make
go build -o terraform-provider-prismacloudcompute
# github.com/PaloAltoNetworks/terraform-provider-prismacloudcompute/prismacloudcompute/convert
prismacloudcompute/convert/admission.go:8:56: undefined: policy.AdmissionRule
prismacloudcompute/convert/admission.go:9:24: undefined: policy.AdmissionRule
prismacloudcompute/convert/admission.go:14:18: undefined: policy.AdmissionRule
prismacloudcompute/convert/admission.go:28:34: undefined: policy.AdmissionRule
make: *** [build] Error 2

I think prisma-cloud-compute-go needs to be tagged, and go.mod needs to be updated.

wfg commented 2 years ago

@hi-artem did you do a

go get github.com/paloaltonetworks/prisma-cloud-compute-go@main

beforehand? That should update go.mod without having to tag the SDK. I use that method during my testing.

hi-artem commented 2 years ago

@wfg ahh... i haven't! works now. I tested the main branch of the provider, and everything looks go.

hi-artem commented 2 years ago

I will close it, since it is in v0.2.0