Closed akingscote closed 4 years ago
:tada: Thanks for opening this pull request! We really appreciate contributors like you! :raised_hands:
Thank you for doing this! Can you please upload a screen shot of the terraform execution from the deployment directory? That will help in approving this change.
@vinayvenkat Not sure what you mean, but ive just checked out my commit and redeployed.
Here is a screenshot of the deployment in progress:
And another:
Here is a screenshot of the deployment completed:
@akingscote This is perfect. Thank you so much for doing this.
:tada: Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! :heart:
Ive updated the azure-two-tier example code to work with new terraform.
Description
Ive added network security group associations, subnet route assoications, fixed a lot of outdated syntax and addressed any fields that no longer work.
There is one piece of information that is missing and ive added it as a comment at the top of the file. You have to manually accept the terms for the PA image. Although, i dont suppose this is anything new, I just couldnt find any mention of it anywhere.
Ive tested the new deployment and it seems to work.
Motivation and Context
The code hasnt been updated in a couple of years and dosent currently work.
How Has This Been Tested?
Tested on a fresh environment. Originally tried to deploy in the UK south region but it failed as the image isnt available there. Switched to westus2 as it originally was and it worked. I had to accept license terms (needs to be done once per subscription) for the PA image.
Screenshots (if appropriate)
Deployment is successful![image](https://user-images.githubusercontent.com/25075013/83877194-01493600-a732-11ea-92af-f292fbc8ef43.png)
Extensions also deploy successfully![image](https://user-images.githubusercontent.com/25075013/83877260-2178f500-a732-11ea-9bb7-1e0c9556e629.png)
Types of changes
-Bug Fix I havent added any new functionality, ive simply uplifted so that it can succesfully be deployed using the latest terraform and azurerm.
Checklist