Solidcloudio terraform 0.13.0 / Azure RM 2.23.0 upgrade

[solidcloudio]

Description

Upgraded the dependencies Terraform and Azure RM to their latest versions.

Motivation and Context

Keep things up to date. I was able to deploy this infrastructure with Terraform 0.13.0 after these changes. Changes are specific to Azure and only updated the Azure Two Tier sample.

How Has This Been Tested?

I created the infrastructure in my Azure account.

Screenshots (if appropriate)

Types of changes

• Upgrade. Terraform v0.13 introduces a new hierarchical namespace for providers that allows specifying both HashiCorp-maintained and community-maintained providers as dependencies of a module, with community providers distributed from other namespaces on Terraform Registry from a third-party provider registry. In order to establish the hierarchical namespace, Terraform now requires explicit source information for any providers that are not HashiCorp-maintained, using a new syntax in the required_providers nested block inside the terraform configuration block: https://www.terraform.io/upgrade-guides/0-13.html

• Interpolation-only expressions are deprecated: an expression like "${foo}" should be rewritten as just foo.

• Added Provider configuration block. - See upgrade guide above.

Azure RM 2.24.0 See Azure Provider change log: https://github.com/terraform-providers/terraform-provider-azurerm/blob/master/CHANGELOG.md

• Changes Azure storage parameters for updated provider.
• Azure subnets now require a list of address_prefixes.
• Added Subnet and NSG association objects.

Checklist

• [x] I have updated the documentation accordingly.
• [x] I have read the CONTRIBUTING document.
• [x] I have added tests to cover my changes if appropriate.
• [ x ] All new and existing tests passed.

[welcome[bot]]

:tada: Thanks for opening this pull request! We really appreciate contributors like you! :raised_hands:

[solidcloudio]

Not in this context... What can be done about these Prisma Cloud errors ?

[solidcloudio]

Question on this.. Is there some documentation or diagram outlining the routing / infrastructure for this azure two tier sample ?

Curious to see the architecture at a higher level

[solidcloudio]

I found the docs and video here https://github.com/PaloAltoNetworks/azure/tree/master/two-tier-sample

[solidcloudio]

https://www.youtube.com/watch?v=vpC62NRpWSM