Add sha-bang for check-fw.sh

PaloAltoNetworks / terraform-templates

This repo contains Terraform templates to deploy infrastructure on AWS and Azure and to secure them using the Palo Alto Networks Next Generation Firewalls

Apache License 2.0

147 stars 151 forks source link

Add sha-bang for check-fw.sh #5

Open tuckner opened 6 years ago

tuckner commented 6 years ago

Tested on Ubuntu 16.04, default interpreter ran by provisioner is /bin/sh causing the script to fail. Adding sha-bang '#!/bin/bash' fixes the issue. Provisioner could also declare the correct interpreter for the script.

Error: null_resource.check_fw_ready (local-exec): ./check_fw.sh: 9: ./check_fw.sh: [[: not found

jeffbrl commented 5 years ago

I struggled for an hour this morning before realizing that Ubuntu 18.04 aliases /bin/sh to dash instead of bash. Why haven't either one of @tuckner's proposed fixes been merged?

chiranjeev2019 commented 4 years ago

@tuckner @jeffbrl could you please help me , i'm deploying palo alto BYOL to test in aws.

the terraform plan command gives this error while interpreting:

Error: Error applying plan:

1 error occurred:

null_resource.check_fw_ready: Error running command './check_fw.sh 54.237.40.71': exit status 1. Output: '.' is not recognized as an internal or external command, operable program or batch file.

jeffbrl commented 4 years ago

@chiranjeev2019 The shell script isn't going to work on Windows.