PaloAltoNetworks / twistlock-defender-helm

Helm Chart to deploy Twistlock Defender
https://paloaltonetworks.github.io/twistlock-defender-helm/
2 stars 2 forks source link

feat: add support for custom CPU and memory requests via Helm values #1

Closed stepanbaghdasaryan closed 1 month ago

stepanbaghdasaryan commented 1 month ago

Description

Currently, there is no possibility to configure resource memory requests for Twistlock Defender daemonsets. Additionally, CPU requests are hardcoded in the template as cpu: "256m". This restricts users' ability to optimize resource allocation and performance for their applications.

Motivation and Context

I propose adding a new feature that allows users to set CPU and memory requests for Twistlock Defender daemonsets via Helm values. This will enable users to provide more fine-grained control over resource allocation, leading to improved application performance and better resource utilization.

How Has This Been Tested?

helm template -n twistlock twistlock-defender . -f values.yaml

Screenshots (if appropriate)

Types of changes

Checklist

stepanbaghdasaryan commented 1 month ago

I have intentionally commented out requests_memory in values.yaml. As a best practice for production environments, one could also configure requests_memory in values.yaml with requests_memory=limits_memory values.