GrantGabbert
commented
2 months ago After looking, the disk space check is included, but only if the candidate version parameter is passed. In the playbooks, that value is set to "panosnetworkoperationsupgradetargetfirewallversion". But that value is only set in the batch incidents and not carried over to the device upgrade incidents. The field set in the device upgrade incidents is "panosnetworkoperationsupgradetargetversion". Should also include the default free_disk_space if not candidate version is included.
Is your feature request related to a problem?
The pan-os-upgrade-assurance package includes a check for free disk space. This should be incorporated in the default readiness check options.
Describe the solution you'd like
Add 'free_disk_space' to the default readiness check.
Describe alternatives you've considered
Another option would be to add the target software version to the readiness check parameters. But that would also require defining the options in the playbook where they're currently using the defaults.
Additional context
When there isn't enough free disk space, the upgrade can fail without providing an intuitive error message. Ideally this check would be included to provide an opportunity to resolve the disk issues before starting the actual upgrade.