PaloAltoNetworks / xsoar-panos-upgrade-automation

XSOAR Content for managing the PAN-OS Upgrade process.
ISC License
2 stars 4 forks source link

License Comparisons Failing #34

Closed GrantGabbert closed 3 months ago

GrantGabbert commented 5 months ago

Describe the bug

With an HA pair, the licenses don't match 100%. From customer environment, issued and authcode don't always match for HA pairs. When this is the case, the comparison fails.

Expected behavior

License comparison shouldn't fail for minor differences such as non-matching issued date or authcode.

Current behavior

License comparison fails for minor differences. Currently the only field excluded from comparison is serial.

Possible solution

Also exclude "issued" and "authcode" from license comparisons. Potentially exclude "expires" as well. Not sure it matters for upgrades if the expiration dates are identical as long as the license hasn't expired on both firewalls.

Steps to reproduce

Upgrade an HA pair of firewalls that have licenses that differ in their issued date and/or authcodes. The snapshot comparison will fail.

Context

Customer's HA firewalls don't always have identical licenses due to several different reasons. Ideally, the upgrade process shouldn't be stopped due to this, unless it would impact the upgrade itself.

Your Environment