search

PalouseRobosub / robosub

Code for the computer on the sub
GNU General Public License v3.0
13 stars 0 forks source link

Bagging undistorted images. #389

Closed Sindorman closed 4 years ago

Sindorman commented 6 years ago

Changed record.launch to bag undistorted images, instead of raw.

This change is Reviewable

ryan-summers commented 6 years ago
:lgtm:

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

irwineffect commented 6 years ago

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

a discussion (no related file): Hey, I ran this change on the sub, for some reason the bags are about 3 times bigger (given the same number of images) when they contain images coming from the undistortion node. I think there's still a bug in our undistortion code, and I propose we try to use the official ROS undistortion node: http://wiki.ros.org/image_proc

Comments from Reviewable

Sindorman commented 6 years ago

Review status: all files reviewed at latest revision, 1 unresolved discussion.

a discussion (no related file):

Previously, irwineffect wrote…
Hey, I ran this change on the sub, for some reason the bags are about 3 times bigger (given the same number of images) when they contain images coming from the undistortion node. I think there's still a bug in our undistortion code, and I propose we try to use the official ROS undistortion node: http://wiki.ros.org/image_proc

Interesting, but that means that our raw bags that were undistorted manually should also be 3 times bigger than raw. Since we always undistorted them through our node, so in the end they are increased in size?

Comments from Reviewable

brennanpeter commented 6 years ago

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

a discussion (no related file):

Previously, Sindorman (Mykhailo Bykhovtsev) wrote…
Interesting, but that means that our raw bags that were undistorted manually should also be 3 times bigger than raw. Since we always undistorted them through our node, so in the end they are increased in size?

I'll merge this in when this discussion gets resolved

Comments from Reviewable

Sindorman commented 6 years ago

@irwineffect James, do you think we can merge this?