Closed hmmwhatsthisdo closed 6 years ago
Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.
src/movement/test/control_system.test, line 2 at r1 (raw file):
<launch> <test test-name="test_control_system" pkg="robosub" type="test_control_system" time-limit="180.0" />
Can you bump it up to 4 minutes instead? I think it's reasonable, but 180 seconds could still time out if under heavy load.
Comments from Reviewable
Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion.
Comments from Reviewable
Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.
src/movement/test/control_system.test, line 2 at r1 (raw file):
Can you bump it up to 4 minutes instead? I think it's reasonable, but 180 seconds could still time out if under heavy load.
Done.
Comments from Reviewable
Reviewed 1 of 1 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Related to #360.
The current time-out for the control system test is a bit too restrictive and is based on real-world time vs simulator time. On systems that have trouble running the simulator close to real-time speed (my R810 is only managing ~0.65x for reasons I'm still investigating), the test is likely to reach the time-out and fail.
This change is