search

PalouseRobosub / robosub_simulator

Robosub Simulator using Gazebo7
4 stars 0 forks source link

Alison/models #106

Closed AlisonB319 closed 6 years ago

AlisonB319 commented 6 years ago

This is the world for the qualification test. The new gate and new pole use the code from the previous gate and pole with updated dimensions and colors. The new world has the sub, gate, and pole in the locations specified by the instructions with the current location of the sub as the Start Point.

This change is Reviewable

Sindorman commented 6 years ago
:lgtm:

Reviewed 6 of 6 files at r1, 1 of 1 files at r2. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

Sindorman commented 6 years ago

It did though said that PR is out of date

irwineffect commented 6 years ago

Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

a discussion (no related file): Looking at gibb_qualification.world, I'm guessing that you placed the objects within Gazebo and then saved the world file? This resulted in the file being 1603 lines long, for context our existing world files are <300 lines long. It seems Gazebo saved a bunch of extra information in that world file that we probably don't want.

a discussion (no related file): On second thought, I think it might be a good idea to call "new_gate" the "qualification_gate", it's a lot more descriptive.

Comments from Reviewable

ryan-summers commented 6 years ago

Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

a discussion (no related file):

Previously, irwineffect wrote…
Looking at `gibb_qualification.world`, I'm guessing that you placed the objects within Gazebo and then saved the world file? This resulted in the file being 1603 lines long, for context our existing world files are <300 lines long. It seems Gazebo saved a bunch of extra information in that world file that we probably don't want.

It looks like the file actually has the model descriptions inside of it instead of 'ing the URI for the models like we do in gibb.world.

Comments from Reviewable

skallaher commented 6 years ago

This PR is going on ice for now as we don't immediately need these models.