search

PalouseRobosub / robosub_simulator

Robosub Simulator using Gazebo7
4 stars 0 forks source link

Corrected significant links #116

Closed ryan-summers closed 6 years ago

ryan-summers commented 6 years ago

The current significant links are for the old transdec world. This updates significant links to the standard 2018 world.

This change is Reviewable

skallaher commented 6 years ago

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

ryan-summers commented 6 years ago

Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

param/simulator.yaml, line 35 at r1 (raw file):

            depth: 0.08

        -   name: "dice_side_a::one_dice"

I think whoever added labels to sloth used the notation dice_NUMBER, so the labels on each of these links needs to be updated to reflect reality.

Comments from Reviewable

ryan-summers commented 6 years ago

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.

param/simulator.yaml, line 35 at r1 (raw file):

Previously, ryan-summers (Ryan Summers) wrote…
I think whoever added labels to sloth used the notation dice_NUMBER, so the labels on each of these links needs to be updated to reflect reality.

Labels have now been updated.

Comments from Reviewable

skallaher commented 6 years ago

Reviewed 1 of 1 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable