Closed ryan-summers closed 6 years ago
Reviewed 4 of 4 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.
CMakeLists.txt, line 18 at r1 (raw file):
std_msgs message_generation robosub
Does the simulator still depend on robosub
after this change?
Comments from Reviewable
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.
CMakeLists.txt, line 18 at r1 (raw file):
Does the simulator still depend on `robosub` after this change?
Yes, our launch files still require the robosub nodes to run.
Comments from Reviewable
@ryan-summers, the .travis.yml
file needs to be updated to include the robosub_msgs
package so that it can be built with them.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.
Comments from Reviewable
Reviewed 1 of 1 files at r2, 1 of 1 files at r3. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.
Comments from Reviewable
All messages moved to robosub_msgs repository.
This change is