Rate Namespace Fixes - Githubissues

PalouseRobosub / robosub_simulator

Robosub Simulator using Gazebo7

4 stars 0 forks source link

Rate Namespace Fixes #84

Closed skallaher closed 7 years ago

skallaher commented 7 years ago

Fixes #69 and adds the hydrophone node into the nodes launched by gazebo.launch by default.

@ryan-summers the rate/sensor parameter is pretty generic, can we update it to be something along the lines of rate/bno_055?

This change is

bkallaher commented 7 years ago

Reviewed 4 of 4 files at r1. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.

Comments from Reviewable

ryan-summers commented 7 years ago

Sure, or do rate/imu

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.

Comments from Reviewable

skallaher commented 7 years ago

Would you like me to do this in this PR or would you want to do it yourself?

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.

Comments from Reviewable

irwineffect commented 7 years ago

Let's just do it in this PR

Reviewed 4 of 4 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks broke.

param/simulator.yaml, line 12 at r1 (raw file):

        euler: 20
        obstacle_pos: 1
        hydrophone_deltas: 10

what do you think of renaming this parameter to just "hydrophones"?

Comments from Reviewable

skallaher commented 7 years ago

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks broke.

param/simulator.yaml, line 12 at r1 (raw file):

Previously, irwineffect wrote…

what do you think of renaming this parameter to just "hydrophones"?

That would be a question for @BigDCross.

Comments from Reviewable

dcrossman commented 7 years ago

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks broke.

param/simulator.yaml, line 12 at r1 (raw file):

Previously, skallaher (Sean Kallaher) wrote…

That would be a question for @BigDCross.

Let's just keep it as hydrophone_deltas since technically they are separate things. hydrophone_deltas are the time differences and hydrophones would be the position differences from the hydrophone node.

Comments from Reviewable

irwineffect commented 7 years ago

Reviewed 2 of 2 files at r2. Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks broke.

Comments from Reviewable

dcrossman commented 7 years ago

Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable