search

PanagiotisGeorgiadis / Elm-DatePicker

A DatePicker package created using Elm 0.19
https://package.elm-lang.org/packages/PanagiotisGeorgiadis/elm-datepicker/latest/
BSD 3-Clause "New" or "Revised" License
11 stars 2 forks source link

Fix "same as ..." checkbox title for double datetime picker. #6

Closed anna-naumova25 closed 4 years ago

anna-naumova25 commented 4 years ago

Hi Panos :) This pull request is to fix the following issue we've found.

https://github.com/PanagiotisGeorgiadis/Elm-DatePicker/blob/master/screenshots/Double-DateTime-RangePicker-2.png

Steps to redproduce:

  1. Open double datetime picker, as on the screenshot above.
  2. Uncheck "same as..." checkbox.
  3. Select different time.
  4. Check the checkbox.

Result: the time is set as pick-up time, which is on the left. But the checkbox says "same as drop-off time". Expected result: the checkbox title should corresponds with the functionality it does.

PanagiotisGeorgiadis commented 4 years ago

Hello there Anna and sorry for the delay in the reply, its been pretty busy! :D The change seems pretty sensible to me and good catch! :D

anna-naumova25 commented 4 years ago

Thank you! Could you please create new release when it's good time?

PanagiotisGeorgiadis commented 4 years ago

Yeap I'll add a comment here once its published :)

PanagiotisGeorgiadis commented 4 years ago

And its gone live! :D Again thanks very much Anna :D

anna-naumova25 commented 4 years ago

Thank you too, Panos! :)