Closed geophpherie closed 4 years ago
docker-compose run
so I started with that. There's really only one version though, using docker exec
commands. I left the docker-compose run
ones in commented out for reference.%1
to %*
to pull in additional args if desired. So not limited to 1.2. I've run the Mac ones using bash, so I'd think they could work for linux?
I'll try them - I've got Linux booted at the moment.
- I changed it from
%1
to%*
to pull in additional args if desired. So not limited to 1. What would you do with the extra arguments? Do the scripts even use the arguments? Do they check that all required arguments are present?
It's really just a pass through to the underlying call. So if you would run manage.py
with multiple args, it'll send them to it. If you pass the wrong values or not enough, it'd be the same as calling it directly the incorrect way. Same with psql
Ah, OK. Meanwhile, the mac
ones work on Linux so the easy thing would be to change the directory name to mac-or-linux
. :-)
okay I can do that quick before we merge.
name: Dev Tools syntax about: Structure for additional dev tools scripts and
docker exec
syntax.What does this do and why?
Moves the existing
manage.py
commands to usingdocker exec
instead ofdocker-compose run
. This allows for attaching to running containers with the shell, rather than spinning up a separate container. I think this is what we want. Adds support for apsql
command. Also includes someREADME.md
changes to explain how to use. Thedocker-compose run
syntax is left in (commented out) for use if we need it.This closes #5. Any new requests for convenience scripts should be opened as new issues.
Additional notes for reviewers
Containers must be running with
docker-compose up
for these to work.Pre-Review Tasks
Place an ‘x’ between the brackets.
[x] I wrote tests covering these changes -N/A
[x ] I reviewed my own PR before asking for review from others
[x ] I added PR comments providing additional context for reviewers where appropriate, or calling attention to especially sensitive changes.
[x ] If deps were added, I verified the licenses - N/A
Verification steps
README.md
here has instructions on running on bothmac
andwin
. Wouldn't mind someone taking a second look to ensure thewin
version is running properly.Screenshots (if appropriate)
Expected outcome on
mac
: