search

PandABlocks / PandABlocks-ioc

Create an IOC from a PandA
Apache License 2.0
1 stars 5 forks source link

stopped polling for changes once the panda is in an err state #108

Closed evalott100 closed 7 months ago

evalott100 commented 7 months ago

Closes #107

We currently cannot set the alarm state of an out record in softioc, however the new PV PANDA:Status will still work for our cluster liveness check.

We also need to make a corresponding change in the client to break out of the loop in asyncio.AsyncioClient._ctrl_read_forever if we receive no bytes.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 96.29630% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.87%. Comparing base (e4c51ea) to head (caa753f).

Files Patch % Lines
src/pandablocks_ioc/_connection_status.py 94.11% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #108 +/- ## ========================================== + Coverage 90.02% 90.87% +0.84% ========================================== Files 7 8 +1 Lines 1203 1227 +24 Branches 192 194 +2 ========================================== + Hits 1083 1115 +32 + Misses 82 74 -8 Partials 38 38 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

evalott100 commented 7 months ago

Now if there's a TimeoutError the ioc closes the client after going into an alarm state. The client doesn't deal with the PandA's unresponsiveness.