search

PandABlocks / PandABlocks-ioc

Create an IOC from a PandA
Apache License 2.0
1 stars 5 forks source link

removed top level pvi structure which wasn't present in 0.9 #146

Closed evalott100 closed 3 weeks ago

evalott100 commented 3 weeks ago

Closes #144

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.73%. Comparing base (ba12ee2) to head (c819a32). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #146 +/- ## ========================================== - Coverage 91.78% 91.73% -0.06% ========================================== Files 8 8 Lines 1400 1391 -9 Branches 164 163 -1 ========================================== - Hits 1285 1276 -9 Misses 82 82 Partials 33 33 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

evalott100 commented 3 weeks ago

The cause was this:

https://github.com/PandABlocks/PandABlocks-ioc/blob/7626f2a2365b5f50f33df00399b1dbf6102b08db/src/pandablocks_ioc/_pvi.py#L390-L418

coretl commented 3 weeks ago

Please can you post the output of pvget -v PANDA:PVI with this change here?

evalott100 commented 3 weeks ago

@coretl

Please can you post the output of pvget -v PANDA:PVI with this change here?

[:)] pvget -v PANDA1:PVI    
PANDA1:PVI structure 
    structure record
        structure _options
            boolean atomic true
    structure pvi
        structure bits
            string d PANDA1:BITS:PVI
        structure calc1
            string d PANDA1:CALC1:PVI
        structure calc2
            string d PANDA1:CALC2:PVI
        structure clock1
            string d PANDA1:CLOCK1:PVI
        structure clock2
            string d PANDA1:CLOCK2:PVI
        structure counter1
            string d PANDA1:COUNTER1:PVI
        structure counter2
            string d PANDA1:COUNTER2:PVI
        structure counter3
            string d PANDA1:COUNTER3:PVI
        structure counter4
            string d PANDA1:COUNTER4:PVI
        structure counter5
            string d PANDA1:COUNTER5:PVI
        structure counter6
            string d PANDA1:COUNTER6:PVI
        structure counter7
            string d PANDA1:COUNTER7:PVI
        structure counter8
            string d PANDA1:COUNTER8:PVI
        structure data
            string d PANDA1:DATA:PVI
        structure div1
            string d PANDA1:DIV1:PVI
        structure div2
            string d PANDA1:DIV2:PVI
        structure filter1
            string d PANDA1:FILTER1:PVI
        structure filter2
            string d PANDA1:FILTER2:PVI
        structure inenc1
            string d PANDA1:INENC1:PVI
        structure inenc2
            string d PANDA1:INENC2:PVI
        structure inenc3
            string d PANDA1:INENC3:PVI
        structure inenc4
            string d PANDA1:INENC4:PVI
        structure lut1
            string d PANDA1:LUT1:PVI
        structure lut2
            string d PANDA1:LUT2:PVI
        structure lut3
            string d PANDA1:LUT3:PVI
        structure lut4
            string d PANDA1:LUT4:PVI
        structure lut5
            string d PANDA1:LUT5:PVI
        structure lut6
            string d PANDA1:LUT6:PVI
        structure lut7
            string d PANDA1:LUT7:PVI
        structure lut8
            string d PANDA1:LUT8:PVI
        structure lvdsin1
            string d PANDA1:LVDSIN1:PVI
        structure lvdsin2
            string d PANDA1:LVDSIN2:PVI
        structure lvdsout1
            string d PANDA1:LVDSOUT1:PVI
        structure lvdsout2
            string d PANDA1:LVDSOUT2:PVI
        structure outenc1
            string d PANDA1:OUTENC1:PVI
        structure outenc2
            string d PANDA1:OUTENC2:PVI
        structure outenc3
            string d PANDA1:OUTENC3:PVI
        structure outenc4
            string d PANDA1:OUTENC4:PVI
        structure pcap
            string d PANDA1:PCAP:PVI
        structure pcomp1
            string d PANDA1:PCOMP1:PVI
        structure pcomp2
            string d PANDA1:PCOMP2:PVI
        structure pgen1
            string d PANDA1:PGEN1:PVI
        structure pgen2
            string d PANDA1:PGEN2:PVI
        structure pulse1
            string d PANDA1:PULSE1:PVI
        structure pulse2
            string d PANDA1:PULSE2:PVI
        structure pulse3
            string d PANDA1:PULSE3:PVI
        structure pulse4
            string d PANDA1:PULSE4:PVI
        structure seq1
            string d PANDA1:SEQ1:PVI
        structure seq2
            string d PANDA1:SEQ2:PVI
        structure sfp2_sync_in
            string d PANDA1:SFP2_SYNC_IN:PVI
        structure sfp2_sync_out
            string d PANDA1:SFP2_SYNC_OUT:PVI
        structure sfp3_sync_in
            string d PANDA1:SFP3_SYNC_IN:PVI
        structure sfp3_sync_out
            string d PANDA1:SFP3_SYNC_OUT:PVI
        structure srgate1
            string d PANDA1:SRGATE1:PVI
        structure srgate2
            string d PANDA1:SRGATE2:PVI
        structure srgate3
            string d PANDA1:SRGATE3:PVI
        structure srgate4
            string d PANDA1:SRGATE4:PVI
        structure system
            string d PANDA1:SYSTEM:PVI
        structure ttlin1
            string d PANDA1:TTLIN1:PVI
        structure ttlin2
            string d PANDA1:TTLIN2:PVI
        structure ttlin3
            string d PANDA1:TTLIN3:PVI
        structure ttlin4
            string d PANDA1:TTLIN4:PVI
        structure ttlin5
            string d PANDA1:TTLIN5:PVI
        structure ttlin6
            string d PANDA1:TTLIN6:PVI
        structure ttlout1
            string d PANDA1:TTLOUT1:PVI
        structure ttlout10
            string d PANDA1:TTLOUT10:PVI
        structure ttlout2
            string d PANDA1:TTLOUT2:PVI
        structure ttlout3
            string d PANDA1:TTLOUT3:PVI
        structure ttlout4
            string d PANDA1:TTLOUT4:PVI
        structure ttlout5
            string d PANDA1:TTLOUT5:PVI
        structure ttlout6
            string d PANDA1:TTLOUT6:PVI
        structure ttlout7
            string d PANDA1:TTLOUT7:PVI
        structure ttlout8
            string d PANDA1:TTLOUT8:PVI
        structure ttlout9
            string d PANDA1:TTLOUT9:PVI
    structure value
        structure bits
            string d PANDA1:BITS:PVI
        structure[] calc
            (none)
            structure 
                string d PANDA1:CALC1:PVI
            structure 
                string d PANDA1:CALC2:PVI
        structure[] clock
            (none)
            structure 
                string d PANDA1:CLOCK1:PVI
            structure 
                string d PANDA1:CLOCK2:PVI
        structure[] counter
            (none)
            structure 
                string d PANDA1:COUNTER1:PVI
            structure 
                string d PANDA1:COUNTER2:PVI
            structure 
                string d PANDA1:COUNTER3:PVI
            structure 
                string d PANDA1:COUNTER4:PVI
            structure 
                string d PANDA1:COUNTER5:PVI
            structure 
                string d PANDA1:COUNTER6:PVI
            structure 
                string d PANDA1:COUNTER7:PVI
            structure 
                string d PANDA1:COUNTER8:PVI
        structure data
            string d PANDA1:DATA:PVI
        structure[] div
            (none)
            structure 
                string d PANDA1:DIV1:PVI
            structure 
                string d PANDA1:DIV2:PVI
        structure[] filter
            (none)
            structure 
                string d PANDA1:FILTER1:PVI
            structure 
                string d PANDA1:FILTER2:PVI
        structure[] inenc
            (none)
            structure 
                string d PANDA1:INENC1:PVI
            structure 
                string d PANDA1:INENC2:PVI
            structure 
                string d PANDA1:INENC3:PVI
            structure 
                string d PANDA1:INENC4:PVI
        structure[] lut
            (none)
            structure 
                string d PANDA1:LUT1:PVI
            structure 
                string d PANDA1:LUT2:PVI
            structure 
                string d PANDA1:LUT3:PVI
            structure 
                string d PANDA1:LUT4:PVI
            structure 
                string d PANDA1:LUT5:PVI
            structure 
                string d PANDA1:LUT6:PVI
            structure 
                string d PANDA1:LUT7:PVI
            structure 
                string d PANDA1:LUT8:PVI
        structure[] lvdsin
            (none)
            structure 
                string d PANDA1:LVDSIN1:PVI
            structure 
                string d PANDA1:LVDSIN2:PVI
        structure[] lvdsout
            (none)
            structure 
                string d PANDA1:LVDSOUT1:PVI
            structure 
                string d PANDA1:LVDSOUT2:PVI
        structure[] outenc
            (none)
            structure 
                string d PANDA1:OUTENC1:PVI
            structure 
                string d PANDA1:OUTENC2:PVI
            structure 
                string d PANDA1:OUTENC3:PVI
            structure 
                string d PANDA1:OUTENC4:PVI
        structure pcap
            string d PANDA1:PCAP:PVI
        structure[] pcomp
            (none)
            structure 
                string d PANDA1:PCOMP1:PVI
            structure 
                string d PANDA1:PCOMP2:PVI
        structure[] pgen
            (none)
            structure 
                string d PANDA1:PGEN1:PVI
            structure 
                string d PANDA1:PGEN2:PVI
        structure[] pulse
            (none)
            structure 
                string d PANDA1:PULSE1:PVI
            structure 
                string d PANDA1:PULSE2:PVI
            structure 
                string d PANDA1:PULSE3:PVI
            structure 
                string d PANDA1:PULSE4:PVI
        structure[] seq
            (none)
            structure 
                string d PANDA1:SEQ1:PVI
            structure 
                string d PANDA1:SEQ2:PVI
        structure sfp2_sync_in
            string d PANDA1:SFP2_SYNC_IN:PVI
        structure sfp2_sync_out
            string d PANDA1:SFP2_SYNC_OUT:PVI
        structure sfp3_sync_in
            string d PANDA1:SFP3_SYNC_IN:PVI
        structure sfp3_sync_out
            string d PANDA1:SFP3_SYNC_OUT:PVI
        structure[] srgate
            (none)
            structure 
                string d PANDA1:SRGATE1:PVI
            structure 
                string d PANDA1:SRGATE2:PVI
            structure 
                string d PANDA1:SRGATE3:PVI
            structure 
                string d PANDA1:SRGATE4:PVI
        structure system
            string d PANDA1:SYSTEM:PVI
        structure[] ttlin
            (none)
            structure 
                string d PANDA1:TTLIN1:PVI
            structure 
                string d PANDA1:TTLIN2:PVI
            structure 
                string d PANDA1:TTLIN3:PVI
            structure 
                string d PANDA1:TTLIN4:PVI
            structure 
                string d PANDA1:TTLIN5:PVI
            structure 
                string d PANDA1:TTLIN6:PVI
        structure[] ttlout
            (none)
            structure 
                string d PANDA1:TTLOUT1:PVI
            structure 
                string d PANDA1:TTLOUT2:PVI
            structure 
                string d PANDA1:TTLOUT3:PVI
            structure 
                string d PANDA1:TTLOUT4:PVI
            structure 
                string d PANDA1:TTLOUT5:PVI
            structure 
                string d PANDA1:TTLOUT6:PVI
            structure 
                string d PANDA1:TTLOUT7:PVI
            structure 
                string d PANDA1:TTLOUT8:PVI
            structure 
                string d PANDA1:TTLOUT9:PVI
            structure 
                string d PANDA1:TTLOUT10:PVI