PandABlocks / PandABlocks-ioc

Create an IOC from a PandA
Apache License 2.0
1 stars 5 forks source link

added tests to work with the new gate duration #94

Closed evalott100 closed 9 months ago

evalott100 commented 9 months ago

The ioc side changes for https://github.com/PandABlocks/PandABlocks-client/issues/77

evalott100 commented 9 months ago

Won't work until we merge and release pandablocks-client.

coretl commented 9 months ago

I'm not sure these changes are needed at all? The field GATE_DURATION (or SAMPLES) is not treated as special anywhere in this codebase, it is only the HDF scaling of the client that treats it as special...

evalott100 commented 9 months ago

I'm not sure these changes are needed at all? The field GATE_DURATION (or SAMPLES) is not treated as special anywhere in this codebase, it is only the HDF scaling of the client that treats it as special...

Yeah I suppose this is tested in the client side already, happy to drop