search

PandaDap2006 / Pandas-Falling-Trees

Makes trees fall
https://modrinth.com/mod/pandas-falling-trees
MIT License
14 stars 0 forks source link

[BUG] MC is ending the world and returns to mainmenu, while chopping a tree #21

Closed Cape-City closed 8 months ago

Cape-City commented 1 year ago

Hi,

something isn't as it should be ;)

When Chopping a tree, after the block breaks this happens:

grafik

latest.log

This error wasn't there in version fallingtrees-1.19.3-1.20.1+0.4.3-beta.jar, but in every newer version.

There is also a incompat due your mod and the TreeChop Mod (TreeChop-1.19.3-fabric-0.17.9.jar), but that is not the issue with this crash. I tested it also without TreeChop and MC still ends the world with an error.

PandaDap2006 commented 1 year ago

i will see if i can figure out why this is happening.

natpalmer-e4o4 commented 8 months ago

I have the same issue and was able to track it down to some kind of incompatibility with Immersive Portals.

The exception is being thrown from here:

https://github.com/iPortalTeam/ImmersivePortalsMod/blob/91576a1d146e80cd038d751760923c5d19fdd5e5/imm_ptl_core/src/main/java/qouteall/imm_ptl/core/network/PacketRedirection.java#L40C9-L40C9

[23:57:29] [Netty Server IO #1/ERROR]: [net.fabricmc.fabric.impl.networking.AbstractChanneledNetworkAddon#handle] Encountered exception while handling in channel with name "fallingtrees:break_tree_packet"
java.lang.IllegalArgumentException: Maybe a mod is trying to add entity in a non-server thread. This is probably not ImmPtl's issue
    at org.apache.commons.lang3.Validate.isTrue(Validate.java:159) ~[geckolib-fabric-1.19-3.1.40.jar:?]
    at qouteall.imm_ptl.core.network.PacketRedirection.withForceRedirect(PacketRedirection.java:40) ~[imm_ptl_core-2.3.1-94bc3db1d1e1fb5d.jar:?]
    at net.minecraft.server.network.EntityTrackerEntry.startTracking(EntityTrackerEntry.java:4566) ~[client-intermediary.jar:?]
    at net.minecraft.server.world.ThreadedAnvilChunkStorage$EntityTracker.updateEntityTrackingStatus(ThreadedAnvilChunkStorage.java:2136) ~[client-intermediary.jar:?]
    at net.minecraft.server.world.ThreadedAnvilChunkStorage$EntityTracker.updateTrackedStatus(ThreadedAnvilChunkStorage.java:2099) ~[client-intermediary.jar:?]
    at net.minecraft.server.world.ThreadedAnvilChunkStorage.loadEntity(ThreadedAnvilChunkStorage.java:1198) ~[client-intermediary.jar:?]
    at net.minecraft.server.world.ServerChunkManager.loadEntity(ServerChunkManager.java:477) ~[client-intermediary.jar:?]
    at net.minecraft.server.world.ServerWorld$ServerEntityHandler.startTracking(ServerWorld.java:1560) ~[client-intermediary.jar:?]
    at net.minecraft.server.world.ServerWorld$ServerEntityHandler.startTracking(ServerWorld.java:1538) ~[client-intermediary.jar:?]
    at net.minecraft.server.world.ServerEntityManager.startTracking(ServerEntityManager.java:217) ~[client-intermediary.jar:?]
    at net.minecraft.server.world.ServerEntityManager.addEntity(ServerEntityManager.java:187) ~[client-intermediary.jar:?]
    at net.minecraft.server.world.ServerEntityManager.addEntity(ServerEntityManager.java:168) ~[client-intermediary.jar:?]
    at net.minecraft.server.world.ServerWorld.addEntity(ServerWorld.java:865) ~[client-intermediary.jar:?]
    at net.minecraft.server.world.ServerWorld.spawnEntity(ServerWorld.java:816) ~[client-intermediary.jar:?]
    at me.pandadev.fallingtrees.tree.TreeUtils.breakTree(TreeUtils.java:50) ~[fallingtrees-fabric-0.6-beta+mc1.19.2.jar:?]
    at me.pandadev.fallingtrees.network.BreakTreePacket.serverReceiver(BreakTreePacket.java:27) ~[fallingtrees-fabric-0.6-beta+mc1.19.2.jar:?]
    at dev.architectury.networking.fabric.NetworkManagerImpl.lambda$registerC2SReceiver$0(NetworkManagerImpl.java:79) ~[architectury-6.5.85-fabric.jar:?]
    at dev.architectury.networking.transformers.PacketTransformer$1.inbound(PacketTransformer.java:47) ~[architectury-6.5.85-fabric.jar:?]
    at dev.architectury.networking.fabric.NetworkManagerImpl.lambda$registerC2SReceiver$1(NetworkManagerImpl.java:74) ~[architectury-6.5.85-fabric.jar:?]
    at net.fabricmc.fabric.impl.networking.server.ServerPlayNetworkAddon.receive(ServerPlayNetworkAddon.java:89) ~[fabric-networking-api-v1-1.2.12+def3f86d90-40dbcfca42bb4b90.jar:?]
    at net.fabricmc.fabric.impl.networking.server.ServerPlayNetworkAddon.receive(ServerPlayNetworkAddon.java:38) ~[fabric-networking-api-v1-1.2.12+def3f86d90-40dbcfca42bb4b90.jar:?]
    at net.fabricmc.fabric.impl.networking.AbstractChanneledNetworkAddon.handle(AbstractChanneledNetworkAddon.java:101) [fabric-networking-api-v1-1.2.12+def3f86d90-40dbcfca42bb4b90.jar:?]
    at net.fabricmc.fabric.impl.networking.server.ServerPlayNetworkAddon.handle(ServerPlayNetworkAddon.java:84) [fabric-networking-api-v1-1.2.12+def3f86d90-40dbcfca42bb4b90.jar:?]
    at net.minecraft.server.network.ServerPlayNetworkHandler.handler$ehg000$fabric-networking-api-v1$handleCustomPayloadReceivedAsync(ServerPlayNetworkHandler.java:2561) [client-intermediary.jar:?]
    at net.minecraft.server.network.ServerPlayNetworkHandler.onCustomPayload(ServerPlayNetworkHandler.java) [client-intermediary.jar:?]
    at net.minecraft.network.packet.c2s.play.CustomPayloadC2SPacket.apply(CustomPayloadC2SPacket.java:38) [client-intermediary.jar:?]
    at net.minecraft.network.packet.c2s.play.CustomPayloadC2SPacket.apply(CustomPayloadC2SPacket.java:7) [client-intermediary.jar:?]
    at net.minecraft.network.ClientConnection.handlePacket(ClientConnection.java:167) [client-intermediary.jar:?]
    at net.minecraft.network.ClientConnection.channelRead0(ClientConnection.java:152) [client-intermediary.jar:?]
    at net.minecraft.network.ClientConnection.channelRead0(ClientConnection.java:50) [client-intermediary.jar:?]
    at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:99) [netty-transport-4.1.77.Final.jar:?]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) [netty-transport-4.1.77.Final.jar:?]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) [netty-transport-4.1.77.Final.jar:?]
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357) [netty-transport-4.1.77.Final.jar:?]
    at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410) [netty-transport-4.1.77.Final.jar:?]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) [netty-transport-4.1.77.Final.jar:?]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) [netty-transport-4.1.77.Final.jar:?]
    at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919) [netty-transport-4.1.77.Final.jar:?]
    at io.netty.channel.local.LocalChannel.readInbound(LocalChannel.java:299) [netty-transport-4.1.77.Final.jar:?]
    at io.netty.channel.local.LocalChannel.finishPeerRead0(LocalChannel.java:445) [netty-transport-4.1.77.Final.jar:?]
    at io.netty.channel.local.LocalChannel.access$400(LocalChannel.java:50) [netty-transport-4.1.77.Final.jar:?]
    at io.netty.channel.local.LocalChannel$5.run(LocalChannel.java:403) [netty-transport-4.1.77.Final.jar:?]
    at io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:174) [netty-common-4.1.77.Final.jar:?]
    at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:167) [netty-common-4.1.77.Final.jar:?]
    at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:470) [netty-common-4.1.77.Final.jar:?]
    at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:503) [netty-transport-4.1.77.Final.jar:?]
    at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:995) [netty-common-4.1.77.Final.jar:?]
    at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) [netty-common-4.1.77.Final.jar:?]
    at java.lang.Thread.run(Thread.java:833) [?:?]
PandaDap2006 commented 8 months ago

You would be correct but the code in master is a complete recode of the mod while 1.19.2 is still only the latest released version.

natpalmer-e4o4 commented 8 months ago

Yeah, I realized the more I looked that the whole codebase was completely refactored and wasn't quite that simple of a fix, which led me to delete my second comment. Regardless, thank you for creating this mod!

PandaDap2006 commented 8 months ago

This should not be an issue anymore in the latest version.