Pandarix / BetterArcheology

Fabric Mod that enhances the boring archeology-system in 1.20
https://www.curseforge.com/minecraft/mc-mods/better-archeology
MIT License
12 stars 17 forks source link

World gen bad noise adaptation/ generation above ground #40

Open TheRanker opened 9 months ago

TheRanker commented 9 months ago

2023-12-23_16 21 06

forge 1.20.1 using wwoo as world gen. latest mods/forge version availble. 40.2.18

so seems you have no compat with terralith or wwoo..

Pandarix commented 8 months ago

Most likely, it is not because of incompatibility, but rather a known issue with jigsaw generation.

https://gist.github.com/GentlemanRevvnar/98a8f191f46d28f63592672022c41497#important-info---bugs-and-rules

[...] with large structures sprawling over longer distance creates abnormal terrain distorsion, when not used with "terrain_matching", because the adaptation will stick to the level of the starting structure.

I'll try to find a workaround. Sorry for this weird sight.

TheRanker commented 8 months ago

So... Ur blaming ur bad world gen on forge? When it's only your mod out of my 300+ that has these issues. Gl.

Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: Ruven @.> Sent: Thursday, January 4, 2024 9:02:29 AM To: Pandarix/BetterArcheology @.> Cc: TheRanker @.>; Author @.> Subject: Re: [Pandarix/BetterArcheology] world gen is so bad... needs fixing!! (Issue #40)

Most likely, it is not because of incompatibility, but rather a known issue with jigsaw generation.

https://gist.github.com/GentlemanRevvnar/98a8f191f46d28f63592672022c41497#important-info---bugs-and-rules

[...] with large structures sprawling over longer distance creates abnormal terrain distorsion, when not used with "terrain_matching", because the adaptation will stick to the level of the starting structure.

I'll try to find a workaround. Sorry for this weird sight.

— Reply to this email directly, view it on GitHubhttps://github.com/Pandarix/BetterArcheology/issues/40#issuecomment-1877024154, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABM56HH3KX53XIETEIMDE63YM2ON3AVCNFSM6AAAAABBBAD37WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZXGAZDIMJVGQ. You are receiving this because you authored the thread.Message ID: @.***>

Pandarix commented 8 months ago

I'd appreciate it if we kept this more professional.

Anyways, this was just an early guess as I've just started looking into this issue. That does not mean I won't look into other possibilities. I am not trying to blame others - I would not have shipped this kind of world gen if I had noticed and know that it is my fault for not testing enough. I'll update this thread as soon as I know more.

TheRanker commented 8 months ago

Works fine with vanilla world. Add a world gen mod that changes heights and depths. And your mod chokes and places it's underground on top of the ground .

So not compatible with terralith or wwoo.

Pandarix commented 8 months ago

image image

I got these screenshots straight out of the "vanilla" forge development environment. The incompatibility is more likely just due to the structure not checking if it is generating inside solid blocks or air and not burying it properly. However, yes this problem is worsened by the more extreme world generation of these mods.

katubug commented 7 months ago

I'm adding your mod to a modpack with tectonic so I'm looking forward to this fix! Thank you for working on it!