Pandarix / BushyFlowers

A 1.19 Minecraft fabric mod that enables Players to make Flowers bushier.
Creative Commons Zero v1.0 Universal
1 stars 3 forks source link

When using shaders bushier flowers are shaded differently than normal flowers #6

Open NEALJAN opened 10 months ago

NEALJAN commented 10 months ago

When using shaders (complementary reimagined with iris in my case) bushier flowers are shaded differently than normal flowers

2023-11-19_14 19 01

RashidFTW commented 7 months ago

In addition to the above, the waving in wind feature of shaders (specifically Iris + Complementary Shaders) also doesn't seem to work :(
I have found out however that the resource pack version of this mod waves in the wind and is shaded correctly.

https://github.com/Pandarix/BushyFlowers/assets/160150516/0bb1d4ea-ac18-4b2f-a413-ff7903157b59

leRaeigor commented 6 months ago

This is because Bushier Flowers adds new blocks, that aren't recognized as flowers by default by shaderpacks.

You'll need to open your shaderpack settings, open the shader folder for the one you are using, (you'll need to unzip your shaderpack if it isn't already done) \ Then with a text editor (notebook or whatever you like best), open block.properties.

When inside, you'll see a line starting with : block.10003

This line contains all the blocks the shaderpacks treats as flowers, so you'll add the following at the end of the line : _bushierflowers:grown_dandelion bushierflowers:grown_poppy bushierflowers:grown_blue_orchid bushierflowers:grown_allium bushierflowers:grown_azure_bluet bushierflowers:grown_red_tulip bushierflowers:grown_orange_tulip bushierflowers:grown_white_tulip bushierflowers:grown_pink_tulip bushierflowers:grown_oxeye_daisy bushierflowers:grown_cornflower bushierflowers:grown_lily_of_the_valley bushierflowers:growntorchflower

They should know wave and be shaded the same way as all other flowers ! This is where you can add any modded flowers to wave etc, and by seaching inside this file, you can also add leaves to the leaves line, etc for vines and others. I hope I was clear enough :)

Screenshot below if it can help : Shaderpack_flowers

RashidFTW commented 6 months ago

@leRaeigor Thank you so much for the detailed guide, your comment was very insightful, learned so many new things. I did as you detailed, but since the shaders that I use had the vanilla flowers listed under block.10004, I used that instead. Adding the blocks to the list did indeed fix both the shading and the waving problems I had.

I am not sure if @Pandarix is aware of this fix, but given the widespread use of shaders, I think it should be pinned on here or the mod page. This would help others facing the same issue to find the fix more easily. Personally, for me it was a deal breaker and had me downgrade to the resource pack version, I am glad that I can now fully utilize this great mod!