Pandas-Team / Automatic-Parking

Python implementation of an automatic parallel parking system in a virtual environment, including path planning, path tracking, and parallel parking
GNU General Public License v3.0
327 stars 80 forks source link

README #2

Closed Lecrapouille closed 3 years ago

Lecrapouille commented 3 years ago

Some typo in README.

1/ kinematic.

Currently, written:

The kinematic model of the car is:
x = vcos(ϕ)
y = vsin(ϕ)
v = a
ϕ = vtan(δ)/L

1.1/ Missing derivative symbol '. Should be:

The kinematic model of the car is:
x' = v . cos(ϕ)
y' = v . sin(ϕ)
v' = a
ϕ' = v . tan(δ)/L

1.2/ Missing: a: acceleration, δ: steering angle, ϕ: yaw angle, L: wheelbase, x: x-position, y: y-position, v: velocity 1.3/ v was stuck to cos, sin, tan.

2/ The state vector.

The symbol φ should be ϕ

3/ The input vector

There is a typo a: accellation, δ: steering angle => acceleration :)

amirhosseinh77 commented 3 years ago

Hi there, Thank you very much for your attention and feedback. The typos mentioned have been corrected, and let us know if there is anything else that needs to be corrected. Also, if you have any ideas to improve the code, we will be happy to know.

Lecrapouille commented 3 years ago

Hi, it's fine now ! I'm currently working on this kind of problematic, my maths is poor but in many papers, including your readme, they write like ϕ' = v . tan(δ)/L but I cannot understand why tan() since it looked like to me this should be ϕ' = v . sin(δ)/L. Specially when tan(pi/2) will return infinity (ok this will mean wheels are turned at 90° but, here we meant steering angle).

amirhosseinh77 commented 3 years ago

This website provides some good info: http://planning.cs.uiuc.edu/node658.html I drew this image and it's not that good, but I think it has all the information.

eq

Lecrapouille commented 3 years ago

ok, I forget that was obviously the same angle than the turning radius :) We can close the ticket. Thanks