search

PanderMusubi / inkscape-open-symbols

Open source SVG symbol sets that can be used as Inkscape symbols
MIT License
685 stars 95 forks source link

Add weather icon set #16

Open victorwestmann opened 8 years ago

victorwestmann commented 8 years ago

Hi there. I`d like to propose a new icon set in the next verion of inkscape-open-symbols project.

That would be : https://erikflowers.github.io/weather-icons/

Thanks! :smile: (I'd like to help if needed. By doing this I'll learn all the process and spare you some time. hehe)

Xaviju commented 8 years ago

Hi @victorwestmann I wrote an article on how to create your own symbol library: https://medium.com/@xaviju/creating-your-own-symbol-library-in-inkscape-0-91-and-make-your-front-end-developer-you-338588137aaf

victorwestmann commented 8 years ago

Will try to help this become real. But it should be a nice addition for the list in README.MD I think.

Xaviju commented 8 years ago

If you make a PR with this icon set as a symbol you will be added to the contributors list both in the README (as currently happens with other contributors) and in the github repo contributors list (this is automatically done). You can do it yourself and add it to the readme in the same PR if you want to :)

victorwestmann commented 8 years ago

Done. :smile:

Xaviju commented 8 years ago

I cannot see any PR with this symbol set, are you sure you made it?

victorwestmann commented 8 years ago

I though I just needed to put the name inside the README.MD. Do you want me to personally convert all icons to a new library icon set then?

To be honest I also tried to do that. But failed. Need to investigate a little more on how to do this. Could you advise? It's a font that has icons in it.

Xaviju commented 8 years ago

@victorwestmann sorry for the misunderstanding There is only one way to be added to the README.md: contribute with a set of inkscape symbols. Otherwise contributors are automatically added here: https://github.com/Xaviju/inkscape-open-symbols/graphs/contributors If you add a new set of icons (or help fixing a 'help wanted' issue) your name will be added to the Readme next to the icon set that you helped to create.

Thanks!

victorwestmann commented 8 years ago

I did a small set of icons (SURU-Icons >> Actions-scalable) and it is available right here: https://www.dropbox.com/s/9ybojfeqk05uv15/actions%20scalable%20all.svg?dl=0

230 kb. It was a lot of work but I believe it will work. Can someone, please, test it? :)

Xaviju commented 8 years ago

Wow!!! It works like a charm, but some fixes could be done before PR to improve it:

That would make them almost perfect. :D Hint, the template symbol in the repo its a good exsmple of the structure is should have and yo will see how many code you can delete.

victorwestmann commented 8 years ago

I used the Inkscape XML editor all the time. About the symbols having a name I agree it`s a good idea. The hell of it is that, doing this manually, is a LOT of work. Can't we make a macro or python small script to ge the file name and replace the id tag inside the SVG file with the filename? :)

Another thing... is there a way we can ADD all symbols at once? Like a massive import? This would also make things IMMENSELY easy for other contributors to create and fix Symbol Libraries.

Xaviju commented 8 years ago

Hi @victorwestmann To make them I used to use SVGO and then fix the broken SVGS by replaceing them. Then I used to add the names manually. Yes,its a lot of work.

I am currently working on a python script to create a symbol by using SVGO first and then adding the name of the icon based on the file. Then the work to fix it would be much much smaller. Since I am not a python developer, i need to learn on how to make the regex and stuff...

victorwestmann commented 4 years ago

Hi Xaviju. Merry Christmas! Do you know if you were able to make any progress on your python script regarding this? What is the smallest set of icons someone (like me) could try to tackle?

PanderMusubi commented 6 months ago

Very nice icon set. I hope somebody can help out with this one.