search

PanderMusubi / inkscape-open-symbols

Open source SVG symbol sets that can be used as Inkscape symbols
MIT License
695 stars 94 forks source link

Add Twitter Emoji #24

Open PanderMusubi opened 8 years ago

PanderMusubi commented 8 years ago

Please support SVG symbols from EmojiOne™ (emoji CC-BY) https://github.com/Ranks/emojione and Twitter Emoji for Everyone (twemoji CC-BY) https://github.com/twitter/twemoji

Xaviju commented 8 years ago

I love it! What a great suggestion!

Xaviju commented 8 years ago

I've just uploaded the Emoji One SVG sprite that they offer on the repo. Its a little bit too large and takes some time to load. Could you test it and tell me how is the user experience? https://github.com/Xaviju/inkscape-open-symbols/commit/b0799c8eac0bbd5d47ff0677d390415aef224896

Xaviju commented 8 years ago

emojione

PanderMusubi commented 8 years ago

Yes, it works. Thanks! Can you add the twemoji too?

PS How do you get Inkscape in a dark theme as is in your screenshot?

PanderMusubi commented 8 years ago

Ah, found this on the command line:

/home/pander/.config/inkscape/symbols/emojione.sprites.svg:13240: parser error : Opening and ending tag mismatch: defs line 14 and svg
    </svg>
          ^
/home/pander/.config/inkscape/symbols/emojione.sprites.svg:13241: parser error : Premature end of data in tag svg line 2

which needs fixing. See also related problems in https://github.com/Xaviju/inkscape-open-symbols/issues/21

Xaviju commented 8 years ago

The dark theme is inherited of my desktop theme. Good catch, seems a bad closed SVG tag.

Xaviju commented 8 years ago

Should be fixed here. https://github.com/Xaviju/inkscape-open-symbols/commit/19cb67d9d119baa00409f0a602bb22faf442e18b

Could you please test it? I've also renamed it so better remove the previous one.

PanderMusubi commented 8 years ago

Fixed. Thanks.

PanderMusubi commented 8 years ago

Awaiting ones frm Twitter. Sorry for closing too soon.

goyalyashpal commented 2 years ago

hi, umh, where does this issue stand of now?? i didnt see these listed in the readme file, so.....

Abdur-rahmaanJ commented 2 years ago

@yashpalgoyal1304 EmojiOne already added

PanderMusubi commented 2 years ago

Indeed.

PanderMusubi commented 2 years ago

Twemoji is not yet supported, reponing for that reason.