search

PanderMusubi / inkscape-open-symbols

Open source SVG symbol sets that can be used as Inkscape symbols
MIT License
700 stars 95 forks source link

Sjjb icons #52

Closed Moini closed 7 years ago

Moini commented 7 years ago

The icons are now complete, but they may still require some cleaning (I think the inverted ones are fine aside from xml declaration, but the others may need some styles removed - for the square ones, please keep fill, if it's set to white, and opacity).

I've also edited the licences section of the README, and added the new icon set there.

This was done in a way that assumes that each subfolder (accomodation, transport, food, ....) will get its own iconset file (or the icons in the folder of the same name for inverted and square could also be put together into one iconset file). If you'd prefer to put them all into one, please let me know, then I'll adapt the text accordingly.

The two template files contain the basic text and licence info. They are currently separated by set (square / inverted), and there isn't one for each icon subject (I thought it might be quicker to generate them automatically, if desired).

Please let me know if this is enough for you to go on, or if there's more that I should do.

Moini commented 7 years ago

I also changed the Humble UI license in the README to the licence given in the svg file (so it changed from CC-By-SA 4.0 to MIT). Hope that was correct? There's no licence on the linked Wiki page, so that was the only source I had.

Xaviju commented 7 years ago

I'll check the Pull request code as soon as possible. Thanks for the language fixes

Moini commented 7 years ago

Thank you - I know it's a lot, take your time!

Moini commented 7 years ago

Unrelated, but thought you might like to know: your icon set is mentioned here: https://opensource.com/article/16/12/yearbook-top-open-source-creative-tools-2016

Xaviju commented 7 years ago

Oh, wow. Thanks for the link! :heart_eyes: I was looking at the pull request right now.

Xaviju commented 7 years ago

@Moini Oh, i think I closed this involuntarily. Can you make the pull request again?

Sorry I thought I was closing my own branch! :sweat:

Moini commented 7 years ago

Seems it still worked somehow. Git magic ;-)