search

Pandora-Finance / Modular-contract

Express contract for NFT ecosystem
BSD 3-Clause "New" or "Revised" License
16 stars 5 forks source link

Wrap call response in require function #82

Closed kishan79 closed 2 years ago

parva-jain commented 2 years ago

@kishan79 Isn't that increasing contract size?? What's the need for this change??

kishan79 commented 2 years ago

@parva-jain Yeah, it will add on to the contract size, this was added to avoid unexpected results

sanskarkhare commented 2 years ago

Can we use Reentrancy guard of openzepplin in the functions instead of these wrappers.