Pandora-IsoMemo / Bpred

Bayesian multivariate regression application (Bpred)
https://pandora-isomemo.github.io/Bpred/
GNU General Public License v3.0
0 stars 0 forks source link

Bugs and changes #22

Closed isomemo closed 1 year ago

isomemo commented 1 year ago

@arunge all issues for Bpred regular version are shown in this video: https://youtu.be/8J1vY5tL0-o

file that I tried to upload: test upload.xlsx

arunge commented 1 year ago

@isomemo With version 23.03.1.4 of BPred main and beta I fixed the above points 2., 3., 4.

Regarding 1. The behavior of the shinyMatrix table I cannot change within the app. It would be necessary to changed it directly in the shinyMatrix R package which I am not maintaining. Should I ask Andreas to have a look on that?

Regarding 5. I need to update the download and upload of models anyway, when I want to apply the updated pandora import module (with the new model upload feature) soon. I would suggest to touch this part then and to

Would this be ok for you?

isomemo commented 1 year ago

@arunge on point 1 I cannot comment much other than it sounds reasonable to check with colleagues within INWT on whom can fix the problem.

On point 5, Ok on your suggestion but: change the name of the "Data" tab to "Data/model import/export". Place there both the option to import and export models.

arunge commented 1 year ago

@isomemo Regarding point 1. I could fix the issue with the disappearing header entries with the version 23.03.1.5 of BPred main and beta and this should already work, now.

There is another issue when tabbing through the cells, the focus gets lost when the matrix is extended automatically. I discussed this with Andreas. He is implementing the following behavior:

  • Tabbing from outside into matrix: Set focus to the cell at the top-left
  • Tabbing inside the matrix (except last column): Move to the next column
  • Tabbing from the last column: Set focus to the next element on the page
  • Tabbing backwards inside the matrix (except first column): Move to previous column
  • Tabbing backwards from the first column: Set focus on the previous element on the page

I will let you know when this is available online.

arunge commented 1 year ago

@isomemo The fix regarding the matrix input is online on BPred main and beta. Please, note the logic regarding tabbing mentioned here.

What is left is to update the download/upload part of the UI. I will open a separate issue for this.