Feat/88 duplicates - Githubissues

Pandora-IsoMemo / DSSM

Pandora & IsoMemo spatiotemporal modeling (DSSM)

https://pandora-isomemo.github.io/DSSM/

GNU General Public License v3.0

4 stars 1 forks source link

Feat/88 duplicates #100

Closed f-lukas closed 1 year ago

f-lukas commented 1 year ago

Version 23.02.3

Updates

Option to decide if column with duplicate rows is added
Option to ignore spaces during duplicate detection
Option to specify a string that is used for duplicate detection

f-lukas commented 1 year ago

@arunge could you please check if the new features work as expected? Thanks!

f-lukas commented 1 year ago

Very good that you noticed it. The combination of specifying a string and ignoring spaces didn't work because I only removed the spaces in the data and not in the specified string. It should now work.

f-lukas commented 1 year ago

The reason for this is the same as in https://github.com/Pandora-IsoMemo/iso-app/pull/101#issuecomment-1429941764, where I just implemented a workaround. It is not a bug but cutAllLongStrings only cuts character columns but not factor. There are quite many factor columns in the IsoMemo data sets. Maybe we can add the option to convert factor to character before cutting in cutAllLongStrings. What do you think?