isomemo
commented
1 year ago @arunge You can ignore point 5. Now working! The rest of the points to be checked.
Closed isomemo closed 1 year ago
isomemo
commented
1 year ago @arunge You can ignore point 5. Now working! The rest of the points to be checked.
arunge
commented
1 year ago @isomemo Some updates regarding the points 1. and 2. in the interactive map, and poin 4.
the colour can only be changed in terms of palettes (1). That is, if the colour is fixed, you can still change the palette which will change the colour. I did not implement a different method to colour the points, if "fixed" is selected. Then only the first colour of the palette is used.
regarding the "missing points": They are all there. However, leaflet maps do not repeat any data points, only the map itself is repeated. That is, the center seems to be in the atlantic and data is cutted before Australia on the left (2), but after Australia on the right (3).
Regarding point 4.: The column test contains only one value. Here the determination of default ranges for the plot did fail because minima and maxima values of the colour scale are the same. I fixed this by using at least a small range of colours for the legend in the plot. This is fixed.
Regarding points 3. and 5. I will update you soon.
isomemo
commented
1 year ago @arunge I believe that in the original specification (and later) I requested the possibility of selecting a specific point colour. Please implement this (even if I did not request it before). The current pallete approach is not practical.
Also not practical to have map points appearing in different "leaflets". One of the goals is to export a map with all points in a centred view. Please fix this.
Point 5 is now working! You can ignore this!
Looking forward to the solution of point 3. This was working before.
arunge
commented
1 year ago @isomemo Regarding point 3. There had only been one single change in the relevant part of the code since we shifted all code to our recent repository:
I checked a version from before that change (may 2022) from our archive. Even there the border correction is not working for the Bayes option:
So it was at least not working since the app is open source. The easiest here would be to ask @mgross to check why the border correction is not working. Should we do so?
isomemo
commented
1 year ago @arunge I have no idea about the repository changes and why code would be lost in these transfers. Please fix it so that it works as before. Btw check also if the spherical modelling is working.
arunge
commented
1 year ago Of course, no code was lost in the transfer. We just copied from one repository to another one. I just wanted to say that this issue must be a very old one that has nothing to do with recent changes.
isomemo
commented
1 year ago @arunge what do you mean by very old? And why would things get lost in transfers (old or recent)?
I am worried that other things may have been lost and I will have to check in detail everything which as you know would be very time consuming.
arunge
commented
1 year ago @isomemo As I just said, nothing was lost during the transfer! We copied all existing code into new repositories. With "old" I mean the bug was already present in the version that was copied from the previous repository, that means border correction was already not working for Bayes models before January 2022 (the time when we copied all apps to their new repositories). I will ask @mgross to check why the border correction cannot be seen in the plot.
isomemo
commented
1 year ago @arunge but in that case it comes back to the issue of tracking impacts on software when changes are made (perhaps a package update?). Ask Marcus to also check the spherical modelling as this may have also been impacted.
arunge
commented
1 year ago I opened new issued for the open tasks:
So we can close here
@arunge testing this file on beta version: upload.xlsx
Several things previously working now failing!
1) If I load the data via the Pandora module there are many missing points (compare below map output from "Interactive map" and using "AverageR"
Interactive map
AverageR
2) Has the option to select point colour in the "Interactive map" been made available? I still cannot see it. If I want to set all points to red (instead of default green) how do I do it?
3) Border correction stopped working. If run the AverageR classic model (dependent variable ΔR.14C.yr) and I activate the option "border correction" there is a smooth transition in colours as would be expected. However, this is not working when I select the Bayesian model. This was working before!
Classical model
Bayesian model (notice how colours are broken at longitude 180)
4) In AverageR or TimeR if I select as dependent variable "test" I get the following errors:
Using classic model: 'length.out' must be a non-negative number
Using the Bayesian model: missing values and NaN's not allowed if 'na.rm' is FALSE
5) If I try to use TimeR (same dependent variable as above and "Date type" option selected "single point" and "Mean or lower time point" selected field "Cal.Age.Cal.BP" there is no modelling output. I tested this same data some months ago.
It is rather worrying that so many things that were working now have problems.